Type system / manager overhaul #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
type-system-overhaul
branch
3 times, most recently
from
5c6b31c
to
2aad863
Compare
|
First iteration of this is done. Before I cleanup the type manager itself any more... any first feedback on this? |
KuechA
reviewed
Jun 14, 2023
There was a problem hiding this comment.
I think it's a very good idea to let the frontends generate and parse the types as they have more (specific and relevant) information available and we do not have to assemble a string only to parse it again. I also think that adding this to a frontend shouldn't be problematic in most cases.
It would be good to have one method in the LanguageFrontend which has to be implemented by their instances to generate the type. Currently, they have a different name everywhere. I'd also appreciate to have a common usage pattern provided by the node builder (e.g. pointer(primitiveType("int")) instead of primitiveType("int").reference(POINTER) or so). I think this is not consistent yet.
cpg-language-cxx/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/cxx/CPPLanguage.kt
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Jun 14, 2023
Closed
oxisto
force-pushed
the
type-system-overhaul
branch
from
2a088e7
to
12b828d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
oxisto
force-pushed
the
type-system-overhaul
branch
from
68cbaa2
to
ac4579e
Compare
oxisto
force-pushed
the
type-system-overhaul
branch
4 times, most recently
from
5e814e1
to
6b307b5
Compare
oxisto
force-pushed
the
type-system-overhaul
branch
7 times, most recently
from
ee38bd0
to
3b6e111
Compare
oxisto
force-pushed
the
type-system-overhaul
branch
3 times, most recently
from
ba0de3f
to
340a5f8
Compare
oxisto
force-pushed
the
type-system-overhaul
branch
2 times, most recently
from
5338ea5
to
07ffc9d
Compare
oxisto
force-pushed
the
type-system-overhaul
branch
from
0c5239f
to
023a53d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
oxisto
added a commit
that referenced
this pull request
Jul 27, 2023
This PR contains a complete re-write of the Go language frontend based on JNA instead of a pure Go implementation. While this has a slight performance drawback (I am working on providing some numbers), it has infinitly better debugging capabilities. The handlers and most of the frontend itself is written in Kotlin using our classes and we than use a JNA bridge to a C API wrapper around the Go `go/ast` package. Depends on #1199 Fixes #1256 Fixes #1257 Fixes #1258 Fixes #1259
oxisto
added a commit
that referenced
this pull request
Jul 27, 2023
This PR contains a complete re-write of the Go language frontend based on JNA instead of a pure Go implementation. While this has a slight performance drawback (I am working on providing some numbers), it has infinitly better debugging capabilities. The handlers and most of the frontend itself is written in Kotlin using our classes and we than use a JNA bridge to a C API wrapper around the Go `go/ast` package. Depends on #1199 Fixes #1256 Fixes #1257 Fixes #1258 Fixes #1259
oxisto
added a commit
that referenced
this pull request
Jul 31, 2023
This PR contains a complete re-write of the Go language frontend based on JNA instead of a pure Go implementation. While this has a slight performance drawback (I am working on providing some numbers), it has infinitly better debugging capabilities. The handlers and most of the frontend itself is written in Kotlin using our classes and we than use a JNA bridge to a C API wrapper around the Go `go/ast` package. Depends on #1199 Fixes #1256 Fixes #1257 Fixes #1258 Fixes #1259
oxisto
added a commit
that referenced
this pull request
Jul 31, 2023
This PR contains a complete re-write of the Go language frontend based on JNA instead of a pure Go implementation. While this has a slight performance drawback (I am working on providing some numbers), it has infinitly better debugging capabilities. The handlers and most of the frontend itself is written in Kotlin using our classes and we than use a JNA bridge to a C API wrapper around the Go `go/ast` package. Depends on #1199 Fixes #1256 Fixes #1257 Fixes #1258 Fixes #1259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep Work
TypeManagerto KotlinProblemType, similar toProblemDeclarationandProblemExpressionnewPrimitiveTypeandnewObjectTypeas part of the node buildersFrontends
C/C++ Frontend
newPrimitiveTypeinstead of calling the type parserparseTypewith type parsing in frontend andnewObjectTypeJava Frontend
newPrimitiveTypeinstead of calling the type parserparseTypewith type parsing in frontend andnewObjectTypeLLVM Frontend
newPrimitiveTypeinstead of calling the type parserparseTypewith type parsing in frontend andnewObjectTypeTypeScript Frontend
newPrimitiveTypeinstead of calling the type parserparseTypewith type parsing in frontend andnewObjectTypeGo Frontend
newPrimitiveTypeinstead of calling the type parserparseTypewith type parsing in frontend andnewObjectTypePython Frontend
newPrimitiveTypeinstead of calling the type parserparseTypewith type parsing in frontend andnewObjectTypeCleanup
TypeParserunsigned long long int) to correctly parse all primitive typestypeOffunction in theLanguageFrontend)